Memoize url.resolve #324
Open
Memoize url.resolve #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winkler1
force-pushed
the
memoize-uri-resolve
branch
3 times, most recently
from
1625472
to
61ae9f4
Compare
|
@awwright Any thoughts? The test is just there as a benchmark to demonstrate how much of a hotspot |
|
This seems reasonable. I'll play around with it a bit... I don't know why it would be so expensive, the majority of calls should be trivial to compute (where the URI reference is blank). Also, for the next major version, I was going to pre-compute all of the values before validation. |
Why: * Resolve is an expensive API call This change addresses the need by: * Cache results of last evaluation.
winkler1
force-pushed
the
memoize-uri-resolve
branch
from
61ae9f4
to
dfa7707
Compare
|
I just saw this updated... I'm tagging it 'bug' because it can go out very next release, rather than being a feature enhancement that would bump the minor version number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url.resolveis called once per schema, and once for every field in the schema.URL parsing contributes heavily to execution time, and is unnecessary for simple schemas. I've created a file memoizedResolve.js to cache results of the last call.
Benchmarking shows the following for 10,000 invocations:
284ms with caching
484ms without caching:
return func.apply(null, arguments);in memoizedResolve.jsAdditionally, cache hits will allocate fewer objects and create less GC pressure.