Update filters

Took 13 minutes
tdabasinskas · Jun 8, 2023 · 9c69bab · 9c69bab
1 parent 55dac39
commit 9c69bab
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/backstage/data_source_entities_test.go b/backstage/data_source_entities_test.go
@@ -15,15 +15,17 @@ func TestAccDataSourceEntities(t *testing.T) {
 				Config: testAccProviderConfig + testAccDataSourceEntitiesConfig,
 				Check: resource.ComposeAggregateTestCheckFunc(
 					resource.TestCheckResourceAttr("data.backstage_entities.test", "id", fmt.Sprint([]string{
-						"kind=user",
-						"metadata.name=janelle.dawe",
+						"kind=user,metadata.name=janelle.dawe",
+						"metadata.uid=b70bed0a-e955-4f93-b03f-e03f7954da99",
 					})),
-					resource.TestCheckResourceAttr("data.backstage_entities.test", "entities.#", "1"),
+					resource.TestCheckResourceAttr("data.backstage_entities.test", "entities.#", "2"),
 					resource.TestCheckResourceAttr("data.backstage_entities.test", "entities.0.kind", "User"),
 					resource.TestCheckResourceAttr("data.backstage_entities.test", "entities.0.metadata.annotations.backstage.io/managed-by-location",
 						"url:https://github.com/backstage/backstage/tree/master/packages/catalog-model/examples/acme/team-a-group.yaml"),
 					resource.TestCheckResourceAttr("data.backstage_entities.test", "entities.0.metadata.name", "janelle.dawe"),
+					resource.TestCheckResourceAttr("data.backstage_entities.test", "entities.1.metadata.uid", "b70bed0a-e955-4f93-b03f-e03f7954da99"),
 					resource.TestCheckResourceAttr("data.backstage_entities.test", "entities.0.relations.0.target_ref", "group:default/team-a"),
+					resource.TestCheckResourceAttr("data.backstage_entities.test", "entities.1.relations.0.target_ref", "group:default/team-a"),
 				),
 			},
 		},
@@ -33,8 +35,8 @@ func TestAccDataSourceEntities(t *testing.T) {
 const testAccDataSourceEntitiesConfig = `
 data "backstage_entities" "test" {
   filters = [
-    "kind=user",
-    "metadata.name=janelle.dawe",
+    "kind=user,metadata.name=janelle.dawe",
+    "metadata.uid=b70bed0a-e955-4f93-b03f-e03f7954da99",
   ]
 }
 `
diff --git a/docs/data-sources/entities.md b/docs/data-sources/entities.md
@@ -17,8 +17,8 @@ Use this data source to get a filtered list of [entities](https://backstage.io/d
 data "backstage_entities" "example" {
   // The filters to apply to the query:
   filters = [
-    "kind=User",
-    "metadata.namespace=default",
+    "kind=User,metadata.namespace=default",
+    "kind=Group,metadata.namespace=default",
   ]
 }
 ```

diff --git a/examples/data-sources/backstage_entities/data-source.tf b/examples/data-sources/backstage_entities/data-source.tf
@@ -2,7 +2,7 @@
 data "backstage_entities" "example" {
   // The filters to apply to the query:
   filters = [
-    "kind=User",
-    "metadata.namespace=default",
+    "kind=User,metadata.namespace=default",
+    "kind=Group,metadata.namespace=default",
   ]
 }