Use comparison operators rather than predicate methods

.rubocop.yml

@@ -13,9 +13,11 @@ Metrics/BlockLength:
     - edits.gemspec
     - "tasks/**/*.rake"
 
+Style/NumericPredicate:
+  Enabled: false
 Style/StringLiterals:
   EnforcedStyle: double_quotes
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   EnforcedStyle: with_fixed_indentation
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented

lib/edits/damerau_levenshtein.rb

@@ -26,8 +26,8 @@ def self.distance(seq1, seq2)
 
       rows = seq1.length
       cols = seq2.length
-      return cols if rows.zero?
-      return rows if cols.zero?
+      return cols if rows == 0
+      return rows if cols == 0
 
       # 'infinite' edit distance for padding cost matrix.
       # Can be any value > max[rows, cols]
@@ -78,7 +78,7 @@ def self.distance(seq1, seq2)
 
           matrix[row + 1][col + 1] = cost
 
-          last_match_col = col if sub_cost.zero?
+          last_match_col = col if sub_cost == 0
         end
 
         item_history[seq1_item] = row

lib/edits/jaro.rb

@@ -25,7 +25,7 @@ def self.similarity(seq1, seq2)
       seq2 = seq2.codepoints if seq2.is_a? String
 
       m, t = jaro_matches(seq1, seq2)
-      return 0.0 if m.zero?
+      return 0.0 if m == 0
 
       m = m.to_f
       ((m / seq1.length) + (m / seq2.length) + ((m - t) / m)) / 3
@@ -78,7 +78,7 @@ def self.jaro_matches(seq1, seq2)
         end
       end
 
-      return [0, 0] if matches.zero?
+      return [0, 0] if matches == 0
 
       transposes = 0
       j = 0

lib/edits/levenshtein.rb

@@ -30,8 +30,8 @@ def self.distance(seq1, seq2)
 
       rows = seq1.length
       cols = seq2.length
-      return cols if rows.zero?
-      return rows if cols.zero?
+      return cols if rows == 0
+      return rows if cols == 0
 
       # Initialize first row of cost matrix.
       # The full initial state where cols=3, rows=2 would be:
@@ -82,8 +82,8 @@ def self.distance_with_max(seq1, seq2, max)
 
       rows = seq1.length
       cols = seq2.length
-      return cols > max ? max : cols if rows.zero?
-      return rows > max ? max : rows if cols.zero?
+      return cols > max ? max : cols if rows == 0
+      return rows > max ? max : rows if cols == 0
       return max if (cols - rows) >= max
 
       # array of codepoints outperforms String
@@ -103,7 +103,7 @@ def self.distance_with_max(seq1, seq2, max)
         max_col = row + max
         max_col = cols - 1 if max_col > cols - 1
 
-        prev_col_cost = min_col.zero? ? row + 1 : inf
+        prev_col_cost = min_col == 0 ? row + 1 : inf
         seq1_item = seq1[row]
         diagonal = cols - rows + row
 

lib/edits/restricted_edit.rb

@@ -34,8 +34,8 @@ def self.distance(seq1, seq2)
 
       rows = seq1.length
       cols = seq2.length
-      return cols if rows.zero?
-      return rows if cols.zero?
+      return cols if rows == 0
+      return rows if cols == 0
 
       # retain previous two rows of cost matrix
       lastlast_row = []
@@ -57,8 +57,8 @@ def self.distance(seq1, seq2)
 
         cols.times do |col|
           sub_cost = seq1_item == seq2[col] ? 0 : 1
-          is_swap = sub_cost.positive? &&
-            row.positive? && col.positive? &&
+          is_swap = sub_cost > 0 &&
+            row > 0 && col > 0 &&
             seq1_item == seq2[col - 1] &&
             seq1[row - 1] == seq2[col]
 
@@ -102,8 +102,8 @@ def self.distance_with_max(seq1, seq2, max)
 
       rows = seq1.length
       cols = seq2.length
-      return cols > max ? max : cols if rows.zero?
-      return rows > max ? max : rows if cols.zero?
+      return cols > max ? max : cols if rows == 0
+      return rows > max ? max : rows if cols == 0
       return max if (cols - rows) >= max
 
       # array of codepoints outperforms String
@@ -129,16 +129,16 @@ def self.distance_with_max(seq1, seq2, max)
         max_col = row + max
         max_col = cols - 1 if max_col > cols - 1
 
-        curr_row[min_col] = min_col.zero? ? row + 1 : inf
+        curr_row[min_col] = min_col == 0 ? row + 1 : inf
         seq1_item = seq1[row]
         diagonal = cols - rows + row
 
         min_col.upto(max_col) do |col|
           return max if diagonal == col && last_row[col] >= max
 
           sub_cost = seq1_item == seq2[col] ? 0 : 1
-          is_swap = sub_cost.positive? &&
-            row.positive? && col.positive? &&
+          is_swap = sub_cost > 0 &&
+            row > 0 && col > 0 &&
             seq1_item == seq2[col - 1] &&
             seq1[row - 1] == seq2[col]