Fix regex warnings by removing extra escapes '\' not needed #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Ubuntu 24.04 with Python 3.12 two regexes showed the warning about
invalid escape sequences:
```
aptly/publisher/__init__.py:179: SyntaxWarning: invalid escape sequence '\}'
nodes_raw = re.findall('[ \t]+"([^"]+)".*label="{(Repo|Snapshot|Published) ([^|]+)[^\}"]+}"', dot_data)
aptly/publisher/__init__.py:591: SyntaxWarning: invalid escape sequence '\ '
parsed = re.match('(.*)\ (.*)\ (.*)\ (.*)', ref)
```
Fix those regexes by removing the not needed escapes `\`.
- the `}` inside the `[]` grouping doesn't need to be escaped
- from: https://docs.python.org/3/howto/regex.html#matching-characters
- Metacharacters (except `\`) are not active inside classes.
For example, `[akm$]` will match any of the characters 'a', 'k', 'm', or '$';
'$' is usually a metacharacter, but inside a character class it’s stripped of its special nature.
- the space character ` ` doesn't need to be escaped
Tested on Ubuntu 18.04, 20.04, 22.04 and 24.04 with the `cleanup`
command (which uses the first regex) and the `dump` command
(which uses the second regex)
```sh
python3 -m aptly.publisher -v --url http://example.com/aptly cleanup
python3 -m aptly.publisher -v --url http://example.com/aptly dump --publish "all"
```
Fixes: tcpcloud#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ubuntu 24.04 with Python 3.12 two regexes showed the warning about invalid escape sequences:
Fix those regexes by removing the not needed escapes
\.}inside the[]grouping doesn't need to be escaped\) are not active inside classes. For example,[akm$]will match any of the characters 'a', 'k', 'm', or '$'; '$' is usually a metacharacter, but inside a character class it’s stripped of its special nature.Tested on Ubuntu 18.04, 20.04, 22.04 and 24.04 with the
cleanupcommand (which uses the first regex) and thedumpcommand (which uses the second regex)python3 -m aptly.publisher -v --url http://example.com/aptly cleanup python3 -m aptly.publisher -v --url http://example.com/aptly dump --publish "all"Fixes: #33