Use yaml.safe_load() to fix deprecation and crash #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `yaml.load()` function without a `Loader` keyword is deprecated since `pyyaml 5.1` and removed with `pyyaml 6.0`. Ubuntu 24.04 noble ships with `pyyaml 6.0.1` breaking `python-aptly` and `aptly-publisher`. Fix it by using the recommended `yaml.safe_load()` function. Fixes: tcpcloud#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
yaml.load()function without aLoaderkeyword is deprecated sincepyyaml 5.1and removed withpyyaml 6.0.Ubuntu 24.04 noble ships with
pyyaml 6.0.1breakingpython-aptlyandaptly-publisher.Fix it by using the recommended
yaml.safe_load()function.Fixes: #32
Edit: tested against
aptly 1.5.0+162+g8029305don Ubuntu 20.04, 22.04, 24.04Ubuntu 18.04 is broken since #30 (which fixed the newer Ubuntu versions), so for me this is ok
edit: just to be clear, the only thing not working on Ubuntu 18.04 with the newest master branch is
publish --recreate, justpublishstill works