tas/fastpath: fix incorrect remote window logic on retx #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rx_remote_avail stores the available rx buffer on the remote peer. This field is determined by the window as reported by the remote peer in the TCP segment header. Currently on retransmission, the code reduces the remote window size by tx_sent (data marked for retransmission), while also setting tx_sent=0. This leads to understimation of the flow control window in tcp_txavail(). Fix this in flow_reset_retransmit(). Signed-off-by: Rajath Shashidhara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rx_remote_avail stores the available rx buffer on the remote peer. This field is determined by the window as reported by the remote peer in the TCP segment header.
Currently on retransmission, the code reduces the
remote window size by tx_sent (data marked for retransmission), while also setting tx_sent=0. This leads to understimation of the flow control window in tcp_txavail().
Fix this in flow_reset_retransmit().