Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tint support #161

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

mathieuanthoine
Copy link

Add tint support in the exporter.

AS3 runtime has to be modified to manage it.
There will be a flump-pixi-runtime (haxe) version soon.

@mathieuanthoine mathieuanthoine changed the title Add tint support Adds tint support Oct 13, 2016
@tconkling
Copy link
Owner

Hi @mathieuanthoine, thanks for jumping into this. Tinting support is a good feature to add.

Could you please make sure your commits follow the Flump coding style? My initial concern with these pull requests is that they use tabs instead of spaces and they occasionally don't follow the project's variable and function signature conventions.

That said, for this pull request specifically: why is the tint an Array instead of two separate variables? Is that to support nullability? This should be documented (also document the variable types of the members of the Array).

@mathieuanthoine
Copy link
Author

Hi @tconkling, I have converted tabs to spaces.
What other variables or functions signatures don't fit ? I've tried to be as similar as your code.

Concerning the tint, I chose to use an array instead of two differents properties because these are the two components of a same behaviour.
I haven't chose to create an object with two named properties to avoid verbosity and inflate the file size.

@mathieuanthoine
Copy link
Author

tinit support available on pixi-flump-runtime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants