feat: add nullblob opt everywhere (#18)

* feat: add nullblob opt everywhere * fix(workflows): pass GITHUB_TOKEN
tcodes0 · Sep 6, 2024 · 4d628c5 · 4d628c5
1 parent b694ee0
commit 4d628c5
Show file tree

Hide file tree

Showing 11 changed files with 12 additions and 10 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -24,4 +24,5 @@ jobs:
           BASH_ENV: ./lib.sh
           DRY_RUN: false
           TAGS_FILE: tags.txt
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: ./workflows/release/tag.sh
diff --git a/.github/workflows/release_pr.yml b/.github/workflows/release_pr.yml
@@ -36,14 +36,15 @@ jobs:
         uses: actions/setup-go@v5
         with:
           go-version: 1.23
-      - run: go install github.com/tcodes0/go/cmd/changelog
+      - run: go install github.com/tcodes0/go/cmd/changelog@latest
 
       - name: Update changelog
         shell: bash
         env:
           CHANGELOG_FILE: CHANGELOG.md
           BASH_ENV: ./lib.sh
           TAGS_FILE: tags.txt
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: ./workflows/release/changelog.sh "${{ inputs.url }}" "${{ inputs.title }}" "${{ inputs.tag_prefix }}"
 
       - name: Open PR

diff --git a/ci.sh b/ci.sh
@@ -5,7 +5,7 @@
 # at https://opensource.org/license/BSD-3-clause.
 
 set -euo pipefail
-shopt -s globstar
+shopt -s globstar nullglob
 
 ##########################
 ### vars and functions ###

diff --git a/go/generate_mocks.sh b/go/generate_mocks.sh
@@ -7,7 +7,7 @@
 ### options, imports, mocks ###
 
 set -euo pipefail
-shopt -s globstar
+shopt -s globstar nullglob
 trap 'err $LINENO' ERR
 
 ##########################

diff --git a/go/lint_fix.sh b/go/lint_fix.sh
@@ -5,7 +5,7 @@
 # at https://opensource.org/license/BSD-3-clause.
 
 set -euo pipefail
-shopt -s globstar
+shopt -s globstar nullglob
 trap 'err $LINENO' ERR
 
 ##########################

diff --git a/migration.sh b/migration.sh
@@ -5,7 +5,7 @@
 # at https://opensource.org/license/BSD-3-clause.
 
 set -euo pipefail
-shopt -s globstar
+shopt -s globstar nullglob
 trap 'err $LINENO' ERR
 
 ##########################

diff --git a/template.sh b/template.sh
@@ -7,7 +7,7 @@
 # template for bash scripts
 
 set -euo pipefail
-shopt -s globstar
+shopt -s globstar nullglob
 trap 'err $LINENO' ERR
 
 ##########################

diff --git a/workflows/main/commit_lint.sh b/workflows/main/commit_lint.sh
@@ -7,7 +7,7 @@
 # check that commit messages and PR title are conventional commits
 
 set -euo pipefail
-shopt -s globstar
+shopt -s globstar nullglob
 trap 'err $LINENO' ERR
 
 ##########################

diff --git a/workflows/main/diff.sh b/workflows/main/diff.sh
@@ -7,7 +7,7 @@
 # calls git diff and exists if there are changes
 
 set -euo pipefail
-shopt -s globstar
+shopt -s globstar nullglob
 trap 'err $LINENO' ERR
 
 ##############

diff --git a/workflows/release/changelog.sh b/workflows/release/changelog.sh
@@ -8,7 +8,7 @@
 # Args: 1=url 2=title 3=prefix
 
 set -euo pipefail
-shopt -s globstar
+shopt -s globstar nullglob
 trap 'err $LINENO' ERR
 
 ##########################

diff --git a/workflows/release/tag.sh b/workflows/release/tag.sh
@@ -7,7 +7,7 @@
 # parses changelog and pushes tags the newest release
 
 set -euo pipefail
-shopt -s globstar
+shopt -s globstar nullglob
 trap 'err $LINENO' ERR
 
 ##########################