Skip to content

Commit

Permalink
Merge rust-bitcoin#625: Remove docsrs cfg_attributes
Browse files Browse the repository at this point in the history
81b154f Remove docsrs cfg_attributes (Tobin C. Harding)

Pull request description:

  We no longer need to manually configure the docsrs build to highlight feature guards since we use the `doc_auto_cfg` feature. Somehow when we added usage of that feature we forgot to remove the other attributes.

  Found in CI fail of rust-bitcoin#624

ACKs for top commit:
  sanket1729:
    utACK 81b154f. I don't follow this completely, but yay for removing unnecessary code.
  apoelstra:
    ACK 81b154f

Tree-SHA512: 9decdc3f71d8f592047eee89f7f4aaf3a08b2643148c6bc5ad7de9edf61acab0ee56bf3c6dbc14493a9d089d492e31f1d379539e256b5eb96c8873c3be702256
  • Loading branch information
apoelstra committed Jul 13, 2023
2 parents 9b76e13 + 81b154f commit 8e48e15
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions secp256k1-sys/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ mod macros;
pub mod types;

#[cfg(feature = "recovery")]
#[cfg_attr(docsrs, doc(cfg(feature = "recovery")))]
pub mod recovery;

use core::{slice, ptr};
Expand Down Expand Up @@ -813,7 +812,6 @@ extern "C" {
///
/// The newly created secp256k1 raw context.
#[cfg(all(feature = "alloc", not(rust_secp_no_symbol_renaming)))]
#[cfg_attr(docsrs, doc(cfg(all(feature = "alloc", not(rust_secp_no_symbol_renaming)))))]
pub unsafe fn secp256k1_context_create(flags: c_uint) -> NonNull<Context> {
rustsecp256k1_v0_8_1_context_create(flags)
}
Expand All @@ -824,7 +822,6 @@ pub unsafe fn secp256k1_context_create(flags: c_uint) -> NonNull<Context> {
#[no_mangle]
#[allow(clippy::missing_safety_doc)] // Documented above.
#[cfg(all(feature = "alloc", not(rust_secp_no_symbol_renaming)))]
#[cfg_attr(docsrs, doc(cfg(all(feature = "alloc", not(rust_secp_no_symbol_renaming)))))]
pub unsafe extern "C" fn rustsecp256k1_v0_8_1_context_create(flags: c_uint) -> NonNull<Context> {
use core::mem;
use crate::alloc::alloc;
Expand Down Expand Up @@ -857,15 +854,13 @@ pub unsafe extern "C" fn rustsecp256k1_v0_8_1_context_create(flags: c_uint) -> N
///
/// `ctx` must be a valid pointer to a block of memory created using [`secp256k1_context_create`].
#[cfg(all(feature = "alloc", not(rust_secp_no_symbol_renaming)))]
#[cfg_attr(docsrs, doc(cfg(all(feature = "alloc", not(rust_secp_no_symbol_renaming)))))]
pub unsafe fn secp256k1_context_destroy(ctx: NonNull<Context>) {
rustsecp256k1_v0_8_1_context_destroy(ctx)
}

#[no_mangle]
#[allow(clippy::missing_safety_doc)] // Documented above.
#[cfg(all(feature = "alloc", not(rust_secp_no_symbol_renaming)))]
#[cfg_attr(docsrs, doc(cfg(all(feature = "alloc", not(rust_secp_no_symbol_renaming)))))]
pub unsafe extern "C" fn rustsecp256k1_v0_8_1_context_destroy(mut ctx: NonNull<Context>) {
use crate::alloc::alloc;
secp256k1_context_preallocated_destroy(ctx);
Expand Down

0 comments on commit 8e48e15

Please sign in to comment.