Skip to content

Commit

Permalink
Merge rust-bitcoin#718: Remove check-for-api infrastructure
Browse files Browse the repository at this point in the history
1b0c79c Remove check-for-api infrastructure (Tobin C. Harding)

Pull request description:

  This was a short lived, and unfortunately unsuccessful experiment on how to catch API breaking changes. As we did elsewhere in the org, remove the check-for-api infrastructure.

ACKs for top commit:
  apoelstra:
    ACK 1b0c79c successfully ran local tests

Tree-SHA512: 0fddf186d37af3863428af80ff5c5a941b0d1b40fd4d72b6c1bcf8dec1cb4127446d4d61e19cc12e2ff35a5cd3f98dce0980f913cc38a947dc4d12605b8bebe8
  • Loading branch information
apoelstra committed Aug 5, 2024
2 parents 2753b9e + 1b0c79c commit 4428e08
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 4,781 deletions.
15 changes: 0 additions & 15 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,18 +118,3 @@ jobs:
env:
DO_WASM: true
run: ./contrib/test.sh

API:
name: Check for changes to the public API
runs-on: ubuntu-latest
strategy:
fail-fast: false
steps:
- name: Checkout Crate
uses: actions/checkout@v3
- name: Checkout Toolchain
uses: dtolnay/rust-toolchain@nightly
- name: Install cargo-public-api
run: cargo install --locked cargo-public-api
- name: Running API checker script
run: ./contrib/check-for-api-changes.sh
1,068 changes: 0 additions & 1,068 deletions api/all-features.txt

This file was deleted.

932 changes: 0 additions & 932 deletions api/alloc.txt

This file was deleted.

936 changes: 0 additions & 936 deletions api/default-features.txt

This file was deleted.

959 changes: 0 additions & 959 deletions api/global-context.txt

This file was deleted.

839 changes: 0 additions & 839 deletions api/no-default-features.txt

This file was deleted.

32 changes: 0 additions & 32 deletions contrib/check-for-api-changes.sh

This file was deleted.

0 comments on commit 4428e08

Please sign in to comment.