fixed healthcheck for instances with traefik reverse proxy #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added extra troubleshooting guide
- the "--fail" results in Traefik filtering this container on startup (probably due to delay of the webserver) and somehow never registering its labels
tchapi
reviewed
Jun 3, 2025
Comment on lines
116
to
+117
| HEALTHCHECK --interval=120s --timeout=10s --start-period=30s --retries=3 \ | ||
| CMD curl --fail http://localhost:9000 || exit 1 | ||
| CMD curl http://localhost:9000 || exit 1 |
There was a problem hiding this comment.
While I understand the rationale, I think it's better if we have a strict health check (ie, failing on 5XX or 4XX). Would it help if we bumped the start-period to something like 2min ?
| # User checking their own entry | ||
| ldapsearch -H ldap://lldap-server:3890 -D "uid=someuser,ou=users,dc=domain,dc=com" -W -b "dc=domain,dc=com" "(uid=someuser)" | ||
| ``` | ||
| - check `LDAP_DN_PATTERN` filter to be complaint with your ldap service |
tchapi
force-pushed
the
main
branch
2 times, most recently
from
cfd457d to
ae56070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #201.
Improved readme for ldap users and added troubleshooting guide.
Fixed healthcheck for instances with traefik reverse proxy