Skip to content

Commit

Permalink
install-dependencies.sh: add libxxhash-dev for debian
Browse files Browse the repository at this point in the history 
libxxhash is used for building on both fedora and debian. `xxhash-devel`
is already listed in `fedora_packages`, we should have its counterpart
in `debian_base_packages`. otherwise the build on debian and its
derivatives could fail like

```
CMake Error at /usr/local/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find xxHash (missing: xxhash_LIBRARY xxhash_INCLUDE_DIR) (found
  version "")
Call Stack (most recent call first):
  /usr/local/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindxxHash.cmake:30 (find_package_handle_standard_args)
  CMakeLists.txt:75 (find_package)
```

if we are using CMake to generate the building system. if we use
`configure.py` to generate `build.ninja`, the build would fails at
build time.

Signed-off-by: Kefu Chai <[email protected]>
  • Loading branch information
@tchaikov
tchaikov committed Apr 22, 2024
1 parent 87b08c9 commit 1a86d7c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions install-dependencies.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ debian_base_packages=(
libabsl-dev
librapidxml-dev
libcrypto++-dev
libxxhash-dev
)

fedora_packages=(
Expand Down

0 comments on commit 1a86d7c

Please sign in to comment.