[test262] Add a new staging test for isSubsetOf #3968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL adds a new test to staging directory of test262. Bug: v8:13556 Change-Id: I96966917b9e99ce3c2248845c1cca383d3390aaa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5069373 Reviewed-by: Liviu Rau <[email protected]> Commit-Queue: Liviu Rau <[email protected]> Cr-Commit-Position: refs/heads/main@{#91298}
ljharb
requested changes
Dec 2, 2023
| features: [set-methods] | ||
| ---*/ | ||
|
|
||
| let firstSet = new Set('a', 'b'); |
There was a problem hiding this comment.
this test isn't correct; new Set takes one iterable, not two items.
There was a problem hiding this comment.
You are right. new Set should take an iterable.
There was a problem hiding this comment.
Did the test run in V8 CI? Pass?
There was a problem hiding this comment.
Yes. It seems that it gets the first item 'a' and puts it in the set and ignores the rest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds a new test to staging directory of test262.
Bug: v8:13556
Change-Id: I96966917b9e99ce3c2248845c1cca383d3390aaa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5069373
Reviewed-by: Liviu Rau <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#91298}