Skip to content

yield an undersized window when windows cannot yield at least 1 full one #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

michaelficarra
Copy link
Member

@michaelficarra michaelficarra commented May 13, 2025

This is one of four possible behaviours.

  1. yield no values (empty iterator): current behaviour
  2. throw on .next(): throw on .next() when windows cannot yield at least 1 full window #14
  3. yield a single undersized window: this PR
  4. pad with undefined: pad an undersized first window with undefined #16

Closes #13.

Co-authored-by: Kevin Gibbons <[email protected]>
Co-authored-by: Kevin Gibbons <[email protected]>
@michaelficarra michaelficarra mentioned this pull request May 13, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

behavior of .windows when window size exceeds iterator length
2 participants