Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates the feedback from @michaelficarra in #26 (comment).
specifier
? Isn't it still conceptually a specifier?[[SourceText]]
field: "ECMAScript source text" is probably a better type. Also I wouldn't include the optimisation note for hosts.[[ModuleSource]]
field: like the above rows, we should describe when it's expected to beempty
ModuleSourcesEqual
is a helper function that is necessary for performing identity checks withinHostLoadImportedModule
. Since JS and Wasm modules have independent definitions of this equality, this allows us to implement it for JS, then Wasm can implement it on its own concrete module record, and the HTML spec just needs to call the more generalModuleSourcesEqual
function. We would need to migrate keying into ECMA-262 for this to be called from ECMA-262 directly. Removing the helper function pushes out more complexity into HTML, which is an option, but when I started writing this as an HTML function it just fitted much better here.Sure!