Pass the --module argument to the SM shell in the expected location#141
Open
Ms2ger wants to merge 2 commits intotc39:masterfrom
Open
Pass the --module argument to the SM shell in the expected location#141Ms2ger wants to merge 2 commits intotc39:masterfrom
Ms2ger wants to merge 2 commits intotc39:masterfrom
Conversation
Open
gibson042
requested changes
Apr 8, 2025
Member
gibson042
left a comment
gibson042
left a comment
There was a problem hiding this comment.
I'm suggesting an alternate approach that doesn't introduce a new option.
| } | ||
|
|
||
| this[CHILD_PROCESS] = await this.createChildProcess([tempfile]); | ||
| this[CHILD_PROCESS] = await this.createChildProcess([...options.testHostArgs || [], tempfile]); |
Member
There was a problem hiding this comment.
Suggested change
| this[CHILD_PROCESS] = await this.createChildProcess([...options.testHostArgs || [], tempfile]); | |
| this[CHILD_PROCESS] = await this.createChildProcess([tempfile], options); |
Comment on lines
+21
to
29
| async evalScript(code, options = {}) { | ||
| if (options.module) { | ||
| if (!options.testHostArgs) { | ||
| options.testHostArgs = []; | ||
| } | ||
| options.testHostArgs.push('--module'); | ||
| } | ||
|
|
||
| return super.evalScript(code, options); |
Member
There was a problem hiding this comment.
Rather than mutating options, I think I'd rather have this class override ConsoleAgent createChildProcess (which incidentally removes the need to override evalScript).
Suggested change
| async evalScript(code, options = {}) { | |
| if (options.module) { | |
| if (!options.testHostArgs) { | |
| options.testHostArgs = []; | |
| } | |
| options.testHostArgs.push('--module'); | |
| } | |
| return super.evalScript(code, options); | |
| async createChildProcess(args = [], options = {}) { | |
| if (options.module) { | |
| args = ['--module', ...args]; | |
| } | |
| return super.createChildProcess(args, options); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref tc39/test262-harness#163