-
Notifications
You must be signed in to change notification settings - Fork 199
⬆️ upgrade dependencies, bandage issue with markdown-magic and ansi-styles #1980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
498154e to
3ba666e
Compare
|
This seems fine, but what is the issue with ansi-styles? |
|
@ljharb I didn't dig too deeply, but I'm guessing it's due to v6 going ESM-only |
|
As long as we're on node 22+ tho, that shouldn't matter anymore |
@ljharb remove the override and give it a whirl? |
|
@ljharb the fix is that markdown-magic needs to upgrade ansi-styles and then make this change: - const ansi = require('ansi-styles')
+ const ansi = require('ansi-styles').default
🤷 |
|
looks like the author fixed it in v4.0.4? |
|
@ljharb ugh he decided to inline ansi-styles instead of accepting my patch... |
9622de1 to
b72d23a
Compare
transitive dependency ansi-styles is used by different deps so we need to force the older version