-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow controlled search options #186
base: main
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tbleckert/react-select-search/DoDdb4yfgT85Qof485R4Hgyvu2jT |
Consider making fast-deep-equal an optional dependency and using a less robust one natively
I was able to improve test coverage overall, but I took the |
Prior to version 3 if nothing (as in
null
/undefined
, not an empty array) was returned for thegetOptions
prop the component would continue to use the values passed in theoptions
prop. This is helpful when you want the options to be controlled by your own component rather than managed by theSelectSearch
component. This update should not affect existing behavior.Here's a rough example: