Set BURST to 1 by default for bandwidthratedunqueue #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading 32 packets will lead to very large imprecision in term of byts
tbarbette
temporarily deployed
to
GITLAB_PASSWORD
GitHub Actions
Inactive
tbarbette
temporarily deployed
to
GITLAB_PASSWORD
GitHub Actions
Inactive
|
@mihaibrodschi this looks good now. With the fix it's consistent and I think the new values make sense. |
|
Great! Just one question, from a performance standpoint, isn't setting the burst to 1 the same as (or worse than) disabling batching? |
|
Yes, but the user can set BURST 32, and anyway one should avoid pull mode. In push mode the problem does not happen. |
|
I will add a warning. |
|
Just pushed. If you're up to it you can create something like ExactBandwidthRatedUnqueue which has this internal queue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading 32 packets will lead to very large imprecision in term of byts