updated to phpstan 2 max rules

tbali0524 · Nov 12, 2024 · 0174e9d · 0174e9d
1 parent 95f9988
commit 0174e9d
Show file tree

Hide file tree

Showing 41 changed files with 353 additions and 304 deletions.
diff --git a/.github/workflows/qa.yml b/.github/workflows/qa.yml
@@ -13,7 +13,7 @@ jobs:
         uses: shivammathur/setup-php@v2
         with:
           php-version: "8.3"
-          tools: phpcs:3.10, php-cs-fixer:3.64, phpstan:1.12
+          tools: phpcs:3.10, php-cs-fixer:3.64, phpstan:2.0.1
           coverage: none
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -45,7 +45,7 @@ jobs:
         with:
           php-version: "8.3"
           extensions: mbstring, bcmath, xdebug
-          tools: phpunit:11.3
+          tools: phpunit:11.4
           coverage: xdebug
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

diff --git a/README.md b/README.md
@@ -9,8 +9,8 @@
 * My AoC username: `tbali0524`
 * [Puzzle list](puzzles.md) with topics and my completion status
 * Some [memes](memes.md) from AoC subreddit
-* Link to this repo on [GitHub](https://github.com/tbali0524/advent-of-code-solutions)
-* Link to my _partial_ rewrite of this repo in `Rust` on [GitHub](https://github.com/tbali0524/advent-of-code-rust)
+* Link to [this repo on GitHub](https://github.com/tbali0524/advent-of-code-solutions)
+* Link to my partial [rewrite of the solution in `Rust` on GitHub](https://github.com/tbali0524/advent-of-code-rust)
 
 ## Installation
 

diff --git a/phpstan.dist.neon b/phpstan.dist.neon
@@ -1,10 +1,10 @@
 # PHPStan configuration file.
 #
-# minimum version: ^1.12
+# minimum version: ^2.0.1
 #
 # @see https://phpstan.org/config-reference
 parameters:
-    level: 9
+    level: max
     phpVersion: 80300
     editorUrl: 'vscode://file/%%file%%:%%line%%'
     tmpDir: .tools/phpstan
@@ -14,10 +14,7 @@ parameters:
     excludePaths:
         - .git
         - .tools
+        - .vscode (?)
         - vendor
-    ignoreErrors:
-        -
-          message: '#^(Static )?[Mm]ethod TBali[a-zA-Z0-9\\_]+::[a-zA-Z0-9_]+\(\) is unused\.$#'
-          identifier: method.unused
 includes:
     - phar://phpstan.phar/conf/bleedingEdge.neon
diff --git a/phpunit.xml b/phpunit.xml
@@ -2,13 +2,13 @@
 <!--
 PHPUnit configuration file.
 
-minimum version: ^11.3
+minimum version: ^11.4
 
-@see https://phpunit.readthedocs.io/en/11.3/configuration.html
+@see https://phpunit.readthedocs.io/en/11.4/configuration.html
 -->
 <phpunit
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-    xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.3/phpunit.xsd"
+    xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.4/phpunit.xsd"
     bootstrap="vendor/autoload.php"
     cacheDirectory=".tools/.phpunit.cache/"
     colors="true"
@@ -75,7 +75,6 @@ minimum version: ^11.3
     <coverage
         disableCodeCoverageIgnore="false"
         ignoreDeprecatedCodeUnits="true"
-        includeUncoveredFiles="true"
         pathCoverage="false">
         <report>
             <html outputDirectory=".tools/phpunit-coverage" lowUpperBound="50" highLowerBound="90" />