Skip to content

Commit

Permalink
add screenshot
Browse files Browse the repository at this point in the history
  • Loading branch information
tayfun authored Jul 1, 2019
1 parent f19e973 commit 4ba448e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Github Action to flake8 your pull requests

This is a github action to automatically run flake8 on your pull request and also add annotations if there are errors.

Here be a screenshot
<img width="429" alt="Screenshot 2019-07-01 at 22 45 50" src="https://user-images.githubusercontent.com/55836/60468581-019f9e00-9c52-11e9-805b-6e5c97d2af3a.png">

# but why?

Expand Down Expand Up @@ -48,6 +48,7 @@ I really like the idea behind Github Actions very much. It simplifies devops and

My plan originally was to create a [Github App](https://developer.github.com/apps/quickstart-guides/creating-ci-tests-with-the-checks-api/#introduction), deploy it on AWS using API Gateway and Lambda and use that to run flake8 or anything else I needed. Then I remembered Github Actions. It's much more easier to setup than API Gateways and Lambdas really. What's more, I think it is much more powerful too. With Lambda you are restricted in your environment (Python version this and Node version that etc.) but with Github Actions you can use any image you like.

Well before deciding to write my own linter integrations, I looked into various SaaS solutions and none of them suited me well. Specifically, a lot of them [did not have annotations feature](https://community.sonarsource.com/t/sonarcloud-github-pull-request-analysis-no-inline-comments/7371).

### Gotchas

Expand Down

0 comments on commit 4ba448e

Please sign in to comment.