Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixd dual #164

Merged
merged 10 commits into from
Nov 6, 2023
Merged

mixd dual #164

merged 10 commits into from
Nov 6, 2023

Conversation

j042
Copy link
Member

@j042 j042 commented Oct 4, 2023

extends mixd export to properly set dual information, if needed. This is required for some MUM, e.g., VRDMUM. For easier use, this PR also adds to_subelements() to Faces and Volumes.

@felipegonzalezco - as discussed

fixes #159

@j042 j042 requested a review from clemens-fricke October 4, 2023 13:55
@j042
Copy link
Member Author

j042 commented Oct 4, 2023

@felipegonzalezco is there a case where dual and mrng have different values?

@clemens-fricke
Copy link
Collaborator

I can not really review this due to me not knowing how the dual file/definition is implemented/setup for mixd.

@j042
Copy link
Member Author

j042 commented Oct 4, 2023

I can not really review this due to me not knowing how the dual file/definition is implemented/setup for mixd.

dual information provides element id number of neighboring element at that subelement. A subelement without a neighboring element would be a boundary element, which won't be modified.
Here, we find this interface/connectivity (that's at least what we call it in splinepy), by first extracting subelement centers and creating k-d tree. Then, we call radius_query on the centers themselves. Looping over the results and checking the len of the query hit ensures the uniqueness of the interface. Alternatively, if you don't need to check those and you have funi, you could just loop over the inverse instead and that will be a much faster query

@j042 j042 changed the title Mixd dual mixd dual Oct 5, 2023
@j042 j042 requested a review from jzwar October 5, 2023 07:52
@felipegonzalezco
Copy link

@felipegonzalezco is there a case where dual and mrng have different values?

Sure, in cases where you have immersed boundaries, mrng overwrites the dual info. That's why both files are required in XNS

@j042
Copy link
Member Author

j042 commented Oct 18, 2023

@felipegonzalezco is there a case where dual and mrng have different values?

Sure, in cases where you have immersed boundaries, mrng overwrites the dual info. That's why both files are required in XNS

Ok, that means we shouldn't write over the mrng array. I will update this

@j042 j042 merged commit 88322cb into main Nov 6, 2023
14 of 15 checks passed
@j042 j042 deleted the mixd-dual branch November 6, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dual info missing in mrng
3 participants