Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deep clear #163

Merged
merged 1 commit into from
Oct 12, 2023
Merged

deep clear #163

merged 1 commit into from
Oct 12, 2023

Conversation

j042
Copy link
Member

@j042 j042 commented Oct 3, 2023

use clear(deep=True)

@j042 j042 requested a review from clemens-fricke October 3, 2023 07:51
clemens-fricke
clemens-fricke approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@clemens-fricke clemens-fricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not tell from running the examples and tests if this fixes some of the memory issues we had/improvements its made. But from the documentation, it seems to be a good idea to do it.

Thanks for the addition.

@j042 j042 merged commit dc3bb01 into main Oct 12, 2023
14 checks passed
@j042 j042 deleted the deepclean branch October 12, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemens-fricke clemens-fricke clemens-fricke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j042 @clemens-fricke