Redo #143 #151
Closed
Redo #143 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: clemens.fricke <[email protected]>
Co-authored-by: clemens.fricke <[email protected]>
j042
reviewed
Sep 1, 2023
Comment on lines
+100
to
+102
| meshes[i][0].BC[ | ||
| f"{meshes[j][0].whatami}-nodes" | ||
| ] = np.unique(meshes[j][0].elements) |
There was a problem hiding this comment.
Do you often have BC for edges or is this some sort of masks for faces/volumes?
Comment on lines
+70
to
+79
| meshes = [ | ||
| [ | ||
| meshio_mapping[key][0]( | ||
| vertices=vertices, elements=meshio_mesh.cells_dict[key] | ||
| ), | ||
| meshio_mapping[key][1], | ||
| ] | ||
| for key in meshio_mapping.keys() | ||
| if key in meshio_mesh.cells_dict.keys() | ||
| ] |
There was a problem hiding this comment.
Suggested change
| meshes = [ | |
| [ | |
| meshio_mapping[key][0]( | |
| vertices=vertices, elements=meshio_mesh.cells_dict[key] | |
| ), | |
| meshio_mapping[key][1], | |
| ] | |
| for key in meshio_mapping.keys() | |
| if key in meshio_mesh.cells_dict.keys() | |
| ] | |
| meshes = [ | |
| [ | |
| meshio_mapping[key][0]( | |
| vertices=vertices, elements=meshio_mesh.cells_dict[key] | |
| ), | |
| meshio_mapping[key][1], | |
| ] | |
| for key in meshio_mapping.keys() | |
| if key in meshio_mesh.cells_dict.keys() | |
| ] |
can you please just write a normal for loop here?
Co-authored-by: Jaewook Lee <[email protected]>
Co-authored-by: Jaewook Lee <[email protected]>
Merged
|
Except for the Boundary information, this PR is superseded by #158. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of PR #143 and alternative (?) to #146. I was asked to rebase and I hope this is what was the intention behind that request.