Formatted Codes-for-IR-Remotes consistently as tables #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I don't understand why there are conflicts. I thought my PR was a clean change relative to master. I will investigate... |
robertoostenveld
force-pushed
the
formatting
branch
from
7dbc0c2 to
4fe8bd1
Compare
Make heading levels consistent. Added IR codes for Goodmans, Fishtec, and Edifier, which I missed because my initial PR was based on the development branch but these were added to the master branch.
It turned out that I started off from the development branch. I rebased my changes on the master branch and added the three new devices that I missed. It is now a clean PR relative to master. |
|
This would be a really good one to get merged. That page is a bit of a mess currently |
|
Once it is merged, I also plan to add IR remote codes for my Samsung TV and NAD D3020 audio amplifier. |
|
I think this is a useful change, @robertoostenveld , thank you! There is a merge conflict due to this change:
Could you maybe update your pull request to include this new change? |
|
Sure, done! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page https://tasmota.github.io/docs/Codes-for-IR-Remotes/ had very inconsistent formatting for the different entries.
In this PR I have formatted all lists and tables consistently and made some small cleanups to the headings and to the comments in each section. I have not changed any of the technical content.