Add support for actual start and due dates. #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Issue bean, and JSON parser and reader methods for serializing and deserializing to and from Issue bean. Added new test cases for parser and builder changes. Added json file containing the test data for parser's new UT item.
francton14
changed the title
alexeyOnGitHub
requested changes
Apr 23, 2021
There was a problem hiding this comment.
can you please also add an integration test for this? the new tests only check that the value is added to json or loaded from json.
they do not check whether or not this actually works with Redmine server.
you can run this test against your own Redmine 4.x server and post results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Issue bean, and JSON parser and reader methods for serializing and deserializing to and from Issue bean.
Added new test cases for parser and builder changes.
Added json file containing the test data for parser's new UT item.