fix: potential max block size #6725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 129 suites 43m 36s ⏱️ Results for commit 2ed3696. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests) 2 files 11 suites 41m 28s ⏱️ For more details on these failures, see this check. Results for commit 2ed3696. ♻️ This comment has been updated with latest results. |
hansieodendaal
previously approved these changes
Dec 13, 2024
Co-authored-by: Hansie Odendaal <[email protected]>
Co-authored-by: Hansie Odendaal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes sure that the template does not exceed max weight
Motivation and Context
P2Pool could generate a lot of coinbases, currently the template generation assumes only 1 coinbase is present. This PR takes into account the coinbases when developing the template size