Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable static linking of openssl dependency #6708

Merged

Conversation

hansieodendaal
Copy link
Contributor

Description

Enabled static linking of openssl dependencies by specifying vendored feature where applicable.

Motivation and Context

A recent change introduced a build and runtime dependency on openssl in Windows - this PR removes that dependency by statically linking openssl.

How Has This Been Tested?

System-level testing - queries to the DNS and Tari Pulse resolves.

2024-11-28 16:51:17.816247200 [p2p::initialization] DEBUG Found 9 peer(s) from `seeds.nextnet.tari.com` in 39ms
2024-11-28 16:51:17.861283000 [c::bn::tari_pulse] INFO  Tari Pulse Service initialized with DNS name: checkpoints-nextnet.tari.com
2024-11-28 16:51:18.087188200 [c::bn::tari_pulse] TRACE Passed checkpoints: true, DNS: (45168, 1e3c56468f464072d9879e29a70891e9916f2206116c8819637c266a8b1d2efa), Local: (45168, 1e3c56468f464072d9879e29a70891e9916f2206116c8819637c266a8b1d2efa)

What process can a PR reviewer use to test or verify this change?

Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@hansieodendaal hansieodendaal changed the title chore: enable static linking openssl references to use vendored feature chore: enable static linking of openssl dependency Nov 28, 2024
Copy link

Test Results (CI)

    3 files    129 suites   38m 51s ⏱️
1 344 tests 1 344 ✅ 0 💤 0 ❌
4 030 runs  4 030 ✅ 0 💤 0 ❌

Results for commit 5cb9561.

Copy link

Test Results (Integration tests)

36 tests  +36   36 ✅ +36   14m 21s ⏱️ + 14m 21s
11 suites +11    0 💤 ± 0 
 2 files   + 2    0 ❌ ± 0 

Results for commit 5cb9561. ± Comparison against base commit a75e0c6.

@SWvheerden SWvheerden merged commit 5eb49e0 into tari-project:development Dec 2, 2024
17 of 18 checks passed
@hansieodendaal hansieodendaal deleted the ho_openssl_vendored branch December 4, 2024 06:20
SWvheerden added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants