feat: fix base node shutdown #6697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the base node shutdown on Ubuntu whereas pressing Ctrl-C multiple times rendered the command line interface in an undefined state. This was not issue on Windows. Note: The change to 'base_layer\core\src\base_node\tari_pulse_service\mod.rs' is just to enable testing (get rid of the repeated command-line spam), and will be fixed in tari-project#6696.
Test Results (CI) 3 files 129 suites 39m 22s ⏱️ Results for commit fbf6099. |
SWvheerden
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the base node shutdown on Ubuntu (and hopefully on MacOS) whereas pressing Ctrl-C multiple times rendered the command line interface in an undefined state. This was not issue on Windows.
Note: The change to 'base_layer\core\src\base_node\tari_pulse_service\mod.rs' is an interim change to enable testing (getting rid of the repeated command-line spam) but not required for the base node to shut down. More changes in #6696.
Motivation and Context
The base node did not shut down properly on Ubuntu and MacOs.
How Has This Been Tested?
System-level testing on Windows and Ubuntu (WSL).
What process can a PR reviewer use to test or verify this change?
System-level testing - still outstanding on MacOS
Breaking Changes