Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test!: fix cucumber on libp2p feature branch #6692

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Nov 15, 2024

Description

FIx cucumber tests on libp2p feature branch

Notes:

Motivation and Context

Some tests were failing

How Has This Been Tested?

  • cargo test --release --test cucumber -- --tags "@wallet-ffi and not @broken" --concurrency 1 --retry 2
  • cargo test --release --all-features --test cucumber -- --tags "@critical and (not @long-running) and (not @wallet-ffi) and (not @chat-ffi) and (not @broken)" --concurrency 1 --retry 2

What process can a PR reviewer use to test or verify this change?

Code review
Run the cucumber tests

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

BREAKING CHANGE: Wallet FFI interface change on pub unsafe extern "C" fn comms_config_create

@hansieodendaal hansieodendaal requested review from a team as code owners November 15, 2024 13:59
Copy link

github-actions bot commented Nov 15, 2024

Test Results (CI)

    3 files    126 suites   9m 26s ⏱️
1 161 tests 1 161 ✅ 0 💤 0 ❌
3 483 runs  3 483 ✅ 0 💤 0 ❌

Results for commit d94ea10.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 15, 2024

Test Results (Integration tests)

 2 files  10 suites   15m 53s ⏱️
23 tests 22 ✅ 0 💤 1 ❌
25 runs  23 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit d94ea10.

♻️ This comment has been updated with latest results.

SWvheerden
SWvheerden previously approved these changes Nov 18, 2024
integration_tests/src/wallet_process.rs Outdated Show resolved Hide resolved
@SWvheerden SWvheerden merged commit 316fe77 into tari-project:feat-libp2p Nov 18, 2024
16 of 17 checks passed
@hansieodendaal hansieodendaal deleted the ho_fix_cucumber2 branch November 18, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants