test!: fix cucumber on libp2p feature branch #6692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FIx cucumber tests on libp2p feature branch
Notes:
--concurrency 1
were detected locally, more so for the wallet FFI suite of tests than the normal tests, but--concurrency 1
is recommended for both. This is because addresses are mixed (discoverable) with libp2p when running in the single cucumber process.Motivation and Context
Some tests were failing
How Has This Been Tested?
cargo test --release --test cucumber -- --tags "@wallet-ffi and not @broken" --concurrency 1 --retry 2
cargo test --release --all-features --test cucumber -- --tags "@critical and (not @long-running) and (not @wallet-ffi) and (not @chat-ffi) and (not @broken)" --concurrency 1 --retry 2
What process can a PR reviewer use to test or verify this change?
Code review
Run the cucumber tests
Breaking Changes
BREAKING CHANGE: Wallet FFI interface change on
pub unsafe extern "C" fn comms_config_create