-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sync): unify ban logic in all sync processes #5713
Merged
SWvheerden
merged 7 commits into
tari-project:development
from
mrnaveira:better-sync-ban
Sep 1, 2023
Merged
fix(sync): unify ban logic in all sync processes #5713
SWvheerden
merged 7 commits into
tari-project:development
from
mrnaveira:better-sync-ban
Sep 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
Process - Requires more ACKs or utACKs
P-reviews_required
Process - Requires a review from a lead maintainer to be merged
labels
Sep 1, 2023
stringhandler
previously approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
ghpbot-tari-project
removed
the
P-reviews_required
Process - Requires a review from a lead maintainer to be merged
label
Sep 1, 2023
SWvheerden
previously approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending clippy
mrnaveira
dismissed stale reviews from SWvheerden and stringhandler
via
September 1, 2023 12:03
e9421da
ghpbot-tari-project
added
the
P-reviews_required
Process - Requires a review from a lead maintainer to be merged
label
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P-acks_required
Process - Requires more ACKs or utACKs
P-reviews_required
Process - Requires a review from a lead maintainer to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PeerManager
struct that handles peer bans. All synchronizers reuse this manager to perform the bans.HorizonSyncError
,BlockHeaderSyncError
, etc.) now encapsulates the relationship (and duration) of the bans.Motivation and Context
All sync processes (
header_sync
,block_sync
andhorizon_sync
) handle bans differently., but the recommended approach is the recent block sync refactor (#5691).The purpose of this PR is for all syncs to behave the same and ensure:
How Has This Been Tested?
Tests pass
What process can a PR reviewer use to test or verify this change?
Code review
Breaking Changes