Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle target difficulty conversion failure #5710

Merged
merged 1 commit into from
Sep 1, 2023
Merged

fix: handle target difficulty conversion failure #5710

merged 1 commit into from
Sep 1, 2023

Conversation

brianp
Copy link
Contributor

@brianp brianp commented Sep 1, 2023

Description

Maps the error to the expected result.

Motivation and Context

Just to handle conversion failure mo' betta.

How Has This Been Tested?

CI

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Test Results (CI)

1 196 tests   1 196 ✔️  9m 6s ⏱️
     37 suites         0 💤
       1 files           0 ❌

Results for commit d1dd8e7.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 1, 2023
@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Test Results (Integration tests)

  2 files  +  2  11 suites  +11   14m 12s ⏱️ + 14m 12s
27 tests +27  26 ✔️ +26  0 💤 ±0  1 ❌ +1 
28 runs  +28  27 ✔️ +27  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit d1dd8e7. ± Comparison against base commit 8d84bf5.

@SWvheerden SWvheerden merged commit 431c35a into tari-project:development Sep 1, 2023
12 of 13 checks passed
@brianp brianp deleted the bp-fix-u64-to-usize-expect-usage branch September 1, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianp @SWvheerden @ghpbot-tari-project