feat: add payment id to notify script (#6586)

Description
---
Adds payment_id to the notify scripts

applications/minotari_console_wallet/src/notifier/mod.rs

@@ -37,8 +37,10 @@ use minotari_wallet::{
     WalletSqlite,
 };
 use tari_common_types::transaction::TxId;
+use tari_core::transactions::transaction_components::encrypted_data::PaymentId;
 use tari_utilities::hex::Hex;
 use tokio::{runtime::Handle, sync::broadcast::Sender};
+
 pub const LOG_TARGET: &str = "wallet::notifier";
 pub const RECEIVED: &str = "received";
 pub const SENT: &str = "sent";
@@ -287,6 +289,7 @@ fn args_from_complete(tx: &CompletedTransaction, event: &str, confirmations: Opt
     let amount = format!("{}", tx.amount);
     let status = format!("{}", tx.status);
     let direction = format!("{}", tx.direction);
+    let payment_id = format!("{}", tx.payment_id.clone().unwrap_or(PaymentId::Empty));
 
     let kernel = tx.transaction.body.kernels().first();
     let (excess, public_nonce, signature) = match kernel {
@@ -311,6 +314,7 @@ fn args_from_complete(tx: &CompletedTransaction, event: &str, confirmations: Opt
         amount,
         tx.tx_id.to_string(),
         tx.message.clone(),
+        payment_id,
         tx.source_address.to_base58(),
         tx.destination_address.to_base58(),
         status,

applications/minotari_console_wallet/src/notifier/notify_example.sh

@@ -7,14 +7,15 @@
 #  $2 = amount,
 #  $3 = tx_id
 #  $4 = message
-#  $5 = source address public key
-#  $6 = destination address public key
-#  $7 = status
-#  $8 = excess,
-#  $9 = public_nonce,
-# $10 = signature,
-# $11 = number of confirmations (if applicable, otherwise empty string)
-# $12 = direction
+#  $5 = payment_id
+#  $6 = source address public key
+#  $7 = destination address public key
+#  $8 = status
+#  $9 = excess,
+#  $10 = public_nonce,
+#  $11 = signature,
+#  $12 = number of confirmations (if applicable, otherwise empty string)
+#  $13 = direction
 
 # 2.
 # For transaction "sent" event, we only have the pending outbound transaction:

base_layer/core/src/transactions/transaction_components/encrypted_data.rs

@@ -187,7 +187,7 @@ impl Display for PaymentId {
             PaymentId::U64(v) => write!(f, "{}", v),
             PaymentId::U256(v) => write!(f, "{}", v),
             PaymentId::Address(v) => write!(f, "{}", v.to_emoji_string()),
-            PaymentId::Open(v) => write!(f, "byte vector of len: {}", v.len()),
+            PaymentId::Open(v) => write!(f, "byte vector: {}", v.to_hex()),
             PaymentId::AddressAndData(v, d) => write!(f, "From {} with data: {:?}", v.to_emoji_string(), d),
         }
     }

base_layer/tari_mining_helper_ffi/Cargo.toml

@@ -20,7 +20,6 @@ tari_utilities = { version = "0.7" }
 libc = "0.2.65"
 thiserror = "1.0.26"
 borsh = "1.2"
-hex = "0.4.2"
 tokio = { version = "1.36", features = ["rt"] }
 
 [dev-dependencies]