-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deploy command #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested but LGTM
sdbondi
reviewed
Dec 4, 2024
@@ -57,11 +60,11 @@ pub fn config_override_parser(config_override: &str) -> Result<ConfigOverride, S | |||
return Err(String::from("Override cannot be empty!")); | |||
} | |||
|
|||
let splitted: Vec<&str> = config_override.split("=").collect(); | |||
if splitted.len() != 2 { | |||
let split: Vec<&str> = config_override.split("=").collect(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to use split_once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that this PR must wait with merge until tari-project/tari#6706 and tari-project/tari-dan#1205 gets merged.
Description
Adding a new deploy command which helps to easily deploy any wasm template on L1 Tari network.
Motivation and Context
We needed to have a deploy command in order to easily do development.
How Has This Been Tested?
tari_cli_test.mp4
What process can a PR reviewer use to test or verify this change?
Breaking Changes