Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy command #5

Merged
merged 12 commits into from
Dec 4, 2024
Merged

Conversation

ksrichard
Copy link
Collaborator

Please note that this PR must wait with merge until tari-project/tari#6706 and tari-project/tari-dan#1205 gets merged.

Description

Adding a new deploy command which helps to easily deploy any wasm template on L1 Tari network.

Motivation and Context

We needed to have a deploy command in order to easily do development.

How Has This Been Tested?

tari_cli_test.mp4

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires CLI data directory to be deleted
  • Other - Please specify

Copy link

github-actions bot commented Nov 27, 2024

Test Results (CI)

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 35f2d38. ± Comparison against base commit 21a698f.

♻️ This comment has been updated with latest results.

@ksrichard ksrichard marked this pull request as ready for review December 2, 2024 08:28
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but LGTM

@@ -57,11 +60,11 @@ pub fn config_override_parser(config_override: &str) -> Result<ConfigOverride, S
return Err(String::from("Override cannot be empty!"));
}

let splitted: Vec<&str> = config_override.split("=").collect();
if splitted.len() != 2 {
let split: Vec<&str> = config_override.split("=").collect();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use split_once

@sdbondi sdbondi merged commit 133d7b4 into tari-project:main Dec 4, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants