feat(coinbase-extra): add coinbase extra field #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/cli/commands/util.rs
Outdated
| let share_chain_random_x = InMemoryShareChain::new( | ||
| MAX_BLOCKS_COUNT, | ||
| PowAlgorithm::RandomX, | ||
| Some(block_validation_params.clone()), | ||
| consensus_manager, | ||
| coinbase_extras.clone(), |
There was a problem hiding this comment.
These should be two different hashmaps
There was a problem hiding this comment.
okay, makes sense let me update
src/server/grpc/p2pool.rs
Outdated
| @@ -77,6 +78,8 @@ where S: ShareChain | |||
| stats_max_difficulty_since_last_success: Arc<RwLock<Difficulty>>, | |||
| consensus_manager: ConsensusManager, | |||
| submit_block_semaphore: Arc<Semaphore>, | |||
| tribe: Tribe, | |||
There was a problem hiding this comment.
Let's change this to Squad and replace all instances of tribe with Squad
src/sharechain/in_memory.rs
Outdated
| let mut coinbase_extra = convert_coinbase_extra(tribe.clone(), String::new()).unwrap_or_default(); | ||
| if let Ok(miner_wallet_address) = TariAddress::from_str(key.as_str()) { | ||
| if let Some(coinbase_extra_found) = | ||
| self.find_coinbase_extra(bl.levels.iter(), miner_wallet_address).await |
There was a problem hiding this comment.
This is O(n^2) and will be slow, I think find a better way of doing this without iterating through all the levels
There was a problem hiding this comment.
totally makes sense, let me refactor
There was a problem hiding this comment.
Okay just pushed!
I removed the unneeded iteration, just using the provided coinbase cache and update there the values when adding new blocks to share chain.
stringhandler
merged commit 0139691
into
tari-project:development
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Coinbase extra field is cached now (locally) and use other miners' coinbase extra when possible from share chain for their shares.
Motivation and Context
Coinbase extra field was not supported to be passed to p2pool before, so in order to let miners pass any extra data they want, we need to be able to do that.
Specs for the format of p2pool coinbase extra field: #56
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Breaking Changes