Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: block pool mining if not synced #213

Merged
merged 5 commits into from
Dec 6, 2024
Merged

feat: block pool mining if not synced #213

merged 5 commits into from
Dec 6, 2024

Conversation

SWvheerden
Copy link
Contributor

Description

block pool mining if we are more than 10 blocks out with a sync,
This will allow the node to solo mine, but it wont mine p2pool blocks

stringhandler
stringhandler reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most important part of this is paying the correct shares, but that seems to be missing

src/server/grpc/p2pool.rs Outdated Show resolved Hide resolved
src/server/p2p/network.rs Outdated Show resolved Hide resolved
stringhandler
stringhandler reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also can't see where you set it to true, other than after network silence

SWvheerden and others added 2 commits December 6, 2024 11:48
@SWvheerden
Copy link
Contributor Author

I also can't see where you set it to true, other than after network silence

Diff is not showing it, but its set after catchup sync completes. You only see the change in name, its called synced_bool

@stringhandler stringhandler added this pull request to the merge queue Dec 6, 2024
Merged via the queue into development with commit 503249c Dec 6, 2024
12 of 14 checks passed
@stringhandler stringhandler deleted the sw_block_pool_mining_if_not_synced branch December 6, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SWvheerden @stringhandler