chore: make wallet output not null

[SWvheerden]

Dont allow the wallet ouput json to be null

[gemini-code-assist]

Summary of Changes

Hello @SWvheerden, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enforces data integrity by making the wallet_output_json column in the outputs database table non-nullable. This change streamlines the application's data handling by eliminating the need for optional type checks and null handling in the Rust codebase, ensuring that the wallet_output_json field is always present and valid.

Highlights

• Database Schema Update: The wallet_output_json column in the outputs table has been updated to be NOT NULL, ensuring that all entries in this column must contain a value.
• Database Migration Script: A new migration script (00025-make_wallet_output_json_not_null/up.sql) has been added to handle the schema change. This script recreates the outputs table, copying only existing rows where wallet_output_json is not null, and then re-establishes all associated indexes.
• Rust Code Refactoring: The Rust code has been refactored to reflect the NOT NULL constraint. This includes changing Option<String> to String for wallet_output_json in relevant structs and removing redundant IS NOT NULL checks from SQL queries, simplifying data access logic.

Changelog

• docs/db/db_schema.sql
  • Modified the outputs table definition to set wallet_output_json as TEXT NOT NULL.
• migrations/00025-make_wallet_output_json_not_null/up.sql
  • Added a new migration script to transition the outputs table to enforce the NOT NULL constraint on wallet_output_json.
  • The script drops existing indexes, creates a new table (outputs_new) with the updated constraint, copies valid data, drops the old table, renames the new table, and recreates all indexes.
• src/db/outputs.rs
  • Updated get_output_info_by_hash to directly use wallet_output_json as String, removing ok_or_else.
  • Changed wallet_output_json type from Option<String> to String in WalletOutputRow struct.
  • Removed AND wallet_output_json IS NOT NULL clauses from SQL queries in fetch_unspent_outputs, fetch_outputs_by_lock_request_id, and get_total_unspent_balance.
  • Simplified data processing loops in fetch_unspent_outputs and fetch_outputs_by_lock_request_id by removing if let Some(...).
• src/transactions/displayed_transaction_processor/resolver/database.rs
  • Adjusted the type retrieval for wallet_output_json from Option<String> to String.
  • Removed the ok_or_else call for wallet_output_json as it is now guaranteed to be non-null.

Activity

• No human activity (comments, reviews) has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully enforces a NOT NULL constraint on the wallet_output_json column in the outputs table. The database migration correctly handles SQLite's limitations by recreating the table and migrating only non-null data. Corresponding Rust code has been updated to reflect this change, removing Option wrappers and IS NOT NULL checks, which simplifies the code and improves type safety by leveraging the database constraint.