oncall: limit HistoryBySchedule to 3 concurrent calls #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to test this by pulling into my branch on #3231 and see if the issue is resolved |
Forfold
approved these changes
Oct 4, 2023
KatieMSB
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a mechanism to throttle concurrent history queries, preventing the exhaustion of the database connection pool. This is accomplished by introducing a histLim channel to limit the number of concurrent operations.
Additional Info:
The added code limits the concurrent history queries to a maximum of 3. This is to ensure that the database connection pool is not overwhelmed, especially given that these operations can be expensive and may hold a transaction open for extended periods.