-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gql: add field "assignedSchedules" to type "User" #3231
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
67ffbbf
add target to OnCallShift in schema
Forfold e44e603
inline call
Forfold b21f911
update schema - todo: gql hanging on query
Forfold 582489c
remove temp sched broken ref
Forfold 5915bee
limit HistoryBySchedule to 3 concurrent calls
mastercactapus c9e5a64
Merge remote-tracking branch 'origin/master' into oncallshift-target
Forfold b62e633
Merge remote-tracking branch 'origin/limit-concurrent-history-queries…
Forfold bc869d3
Merge branch 'master' into oncallshift-target
Forfold 13917eb
fix tests
Forfold 5312895
revert
Forfold 632c55b
use sqlc
Forfold 9462382
fix
Forfold 1573078
move
Forfold 3f588bd
lint
Forfold b97c206
use validate many
Forfold 90fd43a
remove unused used userIDs arg
Forfold bd4bad7
simplify query calls
Forfold 00c6f05
use passed db for transaction
Forfold 5fbe9a9
fix func call
Forfold 5e79271
convert to NullUUID within gql layer
Forfold e401382
remove unused query reference
Forfold 170815c
fix query reference
Forfold File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment, but should we avoid "magic numbers" like the 50 used here and above in
end.After(start.AddDate(0, 0, 50
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's an issue with most of our calls to
validate.ManyUUID
, so I'm going to document that for its own issue, if possible