Disable box.cfg #445
Merged
Disable box.cfg #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serpentian
force-pushed
the
gh-428-disable-box-cfg
branch
2 times, most recently
from
ae87d5f to
140fb0e
Compare
Serpentian
force-pushed
the
gh-428-disable-box-cfg
branch
2 times, most recently
from
a7951d4 to
eaf7224
Compare
Serpentian
commented
Nov 20, 2023
Gerold103
reviewed
Nov 22, 2023
Serpentian
force-pushed
the
gh-428-disable-box-cfg
branch
from
eaf7224 to
3119c4b
Compare
Part of tarantool#428 @TarantoolBot document Title: vshard: `box_cfg_mode` cfg option The option can be specified at the root level and regulates, whether vshard calls box.cfg, when vshard.storage is invoked. When specified to 'auto' (default), vshard configures box.cfg on its own. When specified to 'manual', it's user's responsibility to call box.cfg prior to vshard's configuration
In the following commit box.cfg in router will be disabled, it won't accept any box.cfg options and will through error, if some of them are encountered. Let's explicitly use replication_timeout, where it's needed, and don't set it inside vtest during config generation. Needed for tarantool#353 Needed for tarantool#428 NO_DOC=test
Serpentian
force-pushed
the
gh-428-disable-box-cfg
branch
from
3119c4b to
4b56aae
Compare
There is no reason for router to have box configured. It needs neither storage nor listening on a port. This is breaking change, so user's code, which relies on vshard.router.cfg to call box.cfg must be changed. Closes tarantool#353 Closes tarantool#428 @TarantoolBot document Title: vshard: disable box.cfg on routers Since vshard 0.1.25 vshard.router.cfg doesn't call box.cfg and this must be done manually outside of vshard.
Serpentian
force-pushed
the
gh-428-disable-box-cfg
branch
from
4b56aae to
3ef4f80
Compare
Serpentian
commented
Dec 6, 2023
Gerold103
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset cherry picks enum configuration type from
disable user managementPR, introduces option to disable box.cfg on storage and completely drops callingbox.cfgon routers.There won't be any better time for breaking change of disabling box.cfg on routers than release of Tarantool 3.0.0
Closes #353
Closes #428