modules: prepare modules list #1041
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmyger
changed the title
dmyger
force-pushed
the
dmyger/gh-1013-tt_cli_modules_path-env
branch
from
7db5343 to
32f96aa
Compare
dmyger
force-pushed
the
dmyger/gh-1014-prepare-modules-list
branch
from
952086d to
82e3317
Compare
dmyger
force-pushed
the
dmyger/gh-1013-tt_cli_modules_path-env
branch
from
32f96aa to
b8a7313
Compare
dmyger
force-pushed
the
dmyger/gh-1014-prepare-modules-list
branch
from
82e3317 to
dba2492
Compare
oleg-jukovec
approved these changes
Nov 28, 2024
Comment on lines
+86
to
+94
| // for name, path := range externalModules { | ||
| // commandPath := rootCmd.Name() + " " + name | ||
| // modulesInfo[commandPath] = &ModuleInfo{ | ||
| // IsInternal: false, | ||
| // ExternalPath: path, | ||
| // } | ||
| // } |
There was a problem hiding this comment.
The code is unused and should be removed than.
There was a problem hiding this comment.
Add a comment to don't forget adjust the commented code.
There was a problem hiding this comment.
Please, the information into the issue. We don't need such comments in the code since we use CVS and can look back in history.
oleg-jukovec
requested changes
Nov 28, 2024
dmyger
force-pushed
the
dmyger/gh-1013-tt_cli_modules_path-env
branch
from
b8a7313 to
2378be6
Compare
dmyger
force-pushed
the
dmyger/gh-1014-prepare-modules-list
branch
from
dba2492 to
bf17d85
Compare
dmyger
force-pushed
the
dmyger/gh-1013-tt_cli_modules_path-env
branch
from
2378be6 to
7d17211
Compare
dmyger
force-pushed
the
dmyger/gh-1014-prepare-modules-list
branch
from
bf17d85 to
07878bf
Compare
dmyger
force-pushed
the
dmyger/gh-1013-tt_cli_modules_path-env
branch
2 times, most recently
from
288d595 to
95a94bb
Compare
dmyger
force-pushed
the
dmyger/gh-1013-tt_cli_modules_path-env
branch
from
95a94bb to
db292f8
Compare
dmyger
force-pushed
the
dmyger/gh-1014-prepare-modules-list
branch
from
07878bf to
f2d4f80
Compare
dmyger
force-pushed
the
dmyger/gh-1013-tt_cli_modules_path-env
branch
from
db292f8 to
934c56e
Compare
Base automatically changed from
dmyger/gh-1013-tt_cli_modules_path-env
to
master
December 12, 2024 10:07
dmyger
force-pushed
the
dmyger/gh-1014-prepare-modules-list
branch
from
f2d4f80 to
6ca0169
Compare
Find possible modules by manifest.yaml or main executable. Closes #1014
dmyger
force-pushed
the
dmyger/gh-1014-prepare-modules-list
branch
from
6ca0169 to
4639af5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find possible modules by manifest.yaml or main executable.
Closes #1014