Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog: fix formatting #1025

Closed
wants to merge 1 commit into from

Conversation

psergee
Copy link
Collaborator

@psergee psergee commented Nov 17, 2024

No description provided.

@psergee psergee requested a review from dmyger November 17, 2024 17:47
@@ -17,7 +17,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [2.5.2] - 2024-11-07

Update luarocks and libraries version.
- Update luarocks and libraries version.
Copy link
Contributor

@oleg-jukovec oleg-jukovec Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree, this is just a release overview message.

Copy link
Collaborator Author

@psergee psergee Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "release overview message" and why is it in the change log?
Now release notes (brief description of big features/changes for general audience) and change log (a list with detailed descriptions of each change, mostly for devs) are merged. I disagree with this approach, but up to you.

Comment on lines +35 to +39
- Added a number of subcommands for replicaset roles.
- Improved understanding of the version number to install,
- Enhanced status display, and added a flag to disable interactivity when
the application is stopped.
Implemented a number of fixes to improve stability.
- Implemented a number of fixes to improve stability.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same.

@psergee psergee closed this Nov 26, 2024
@psergee psergee deleted the psergee/no-gh-fix-changelog-formatting branch November 26, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants