Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logrotate: don't exit at non-running instance #1006

Merged

Conversation

elhimov
Copy link
Contributor

@elhimov elhimov commented Nov 14, 2024

Just warn that the instance is not running and continue (like tt stop or tt kill do).

Closes #774

@elhimov elhimov force-pushed the elhimov/gh-774-logrotate-exits-at-first-non-running-instance branch from 55bb68e to 2aeec82 Compare November 14, 2024 18:48
@oleg-jukovec oleg-jukovec added the full-ci Enables full ci tests label Nov 15, 2024
@elhimov elhimov force-pushed the elhimov/gh-774-logrotate-exits-at-first-non-running-instance branch 4 times, most recently from 573600a to 81b1dfd Compare November 29, 2024 10:06
@elhimov elhimov force-pushed the elhimov/gh-774-logrotate-exits-at-first-non-running-instance branch 2 times, most recently from 1a43283 to 392b744 Compare December 5, 2024 19:29
Just warn that the instance is not running and continue (like `tt stop`
or `tt kill` do)

Closes #774
@elhimov elhimov force-pushed the elhimov/gh-774-logrotate-exits-at-first-non-running-instance branch from 392b744 to c0b013f Compare December 6, 2024 07:30
Copy link
Contributor

@patapenka-alexey patapenka-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch. LGTM.

@dmyger dmyger merged commit f66fb27 into master Dec 6, 2024
19 of 24 checks passed
@dmyger dmyger deleted the elhimov/gh-774-logrotate-exits-at-first-non-running-instance branch December 6, 2024 11:33
@elhimov elhimov mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Enables full ci tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tt logrotate does not work for started instances if others are stopped
4 participants