crud: fix options for SelectRequest #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when could you merge it? |
After 2 reviews. It could take a while. |
DerekBum
approved these changes
Aug 2, 2023
The patch fixes a typo that made it impossible to setup SelectOpts.After, SelectOpts.BatchSize and SelectOpts.ForceMapCall. Part of #320
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-320-fix-after
branch
from
f83dee3
to
fe566e6
Compare
DifferentialOrange
approved these changes
Aug 3, 2023
|
Thank you. Could you create new release? |
|
At the moment we are not ready for the next major release: |
|
I don't have access to this repository. Could you make m.b. minor release? Or Do you know when will be major release? Because using it's strange :) |
|
We'll make a patch release: #325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch fixes a typo that made it impossible to setup
SelectOpts.After,SelectOpts.BatchSizeandSelectOpts.ForceMapCall.What has been done? Why? What problem is being solved?
I didn't forget about (remove if it is not applicable):
Related issues:
Part of #320