Skip to content

Commit

Permalink
github: add template for pull-request description
Browse files Browse the repository at this point in the history
Commit for #153 introduces changelog and to remind contributors about
changelog entries this commit adds a template for pull-request
description. Learn more about templates on Github in [1].

1. https://docs.github.com/en/github-ae@latest/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository

Follows up #121
  • Loading branch information
ligurio committed Apr 6, 2022
1 parent f208dca commit c5c01a4
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 31 deletions.
9 changes: 9 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
What has been done? Why? What problem is being solved?

I didn't forget about (remove if it is not applicable):

- [ ] Tests (see [documentation](https://pkg.go.dev/testing) for a testing package)
- [ ] Changelog (see [documentation](https://keepachangelog.com/en/1.0.0/) for changelog format)
- [ ] Documentation (see [documentation](https://go.dev/blog/godoc) for documentation style guide)

Related issues:
66 changes: 35 additions & 31 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ First release.

### Fixed

- Fix Upsert() for ConnectionMulti infinite recursive call
- Fixed index out of range panic on dial() to short address
- Fix cast in defaultLogger.Report (#49)
- Fix `Upsert()` for `ConnectionMulti` infinite recursive call
- Fixed index out of range panic on `dial()` to short address
- Fix cast in `defaultLogger.Report` (#49)
- Fix race condition on extremely small request timeouts (#43)
- Fix notify for Connected transition
- Fix reconnection logic and add Opts.SkipSchema()
- Fix notify for `Connected` transition
- Fix reconnection logic and add `Opts.SkipSchema()`
- Fix future sending
- Fix panic on disconnect + timeout
- Fix block on msgpack error
Expand All @@ -61,65 +61,69 @@ First release.
- Report user mismatch error immediately
- Set limit timeout by 0.9 of connection to queue request timeout
- Update fields could be negative
- Require RLimitAction to be specified if RateLimit is specified
- Require `RLimitAction` to be specified if `RateLimit` is specified
- Use newer typed msgpack interface
- Do not start timeouts goroutine if no timeout specified
- Clear buffers on connection close
- Update BenchmarkClientParallelMassive
- Update `BenchmarkClientParallelMassive`
- Remove array requirements for keys and opts
- Do not allocate Response inplace
- Do not allocate `Response` inplace
- Respect timeout on request sending
- Use AfterFunc(fut.timeouted) instead of time.NewTimer()
- Use _vspace/_vindex for introspection
- Method Tuples() always returns table for response
- Use `AfterFunc(fut.timeouted)` instead of `time.NewTimer()`
- Use `_vspace`/`_vindex` for introspection
- Method `Tuples()` always returns table for response

### Removed

- Remove UpsertTyped() method (#23)
- Remove `UpsertTyped()` method (#23)

### Added

- Add Future.WaitChan() and Future.Err() (#86)
- Add `Future.WaitChan()` and `Future.Err()` (#86)
- Get node list from nodes (#81)
- Add method deleteConnectionFromPool()
- Add multiconnections support
- Add Addr() for the connection (#64)
- Add Delete() method for the queue
- Add `Addr()` for the connection (#64)
- Add `Delete()` method for the queue
- Implemented typed taking from queue (#55)
- Add OverrideSchema() method for the connection
- Add `OverrideSchema()` method for the connection
- Add default case to default logger
- Add license (BSD-2 clause as for Tarantool)
- Add GetTyped() method for the connection (#40)
- Add ConfiguredTimeout() for the connection, change queue interface
- Add `GetTyped()` method for the connection (#40)
- Add `ConfiguredTimeout()` for the connection, change queue interface
- Add example for queue
- Add GetQueue() method for the queue
- Add `GetQueue()` method for the queue
- Add queue support
- Add support of Unix socket address
- Add check for prefix "tcp:"
- Add the ability to work with the Tarantool via Unix socket
- Add note about magic way to pack tuples
- Add notification about connection state change
- Add workaround for tarantool/tarantool#2060 (#32)
- Add ConnectedNow() method for the connection
- Add IO deadline and use net.Conn.Set(Read|Write)Deadline
- Add `ConnectedNow()` method for the connection
- Add IO deadline and use `net.Conn.Set(Read|Write)Deadline`
- Add a couple of benchmarks
- Add timeout on connection attempt
- Add RLimitAction option
- Add Call17() for the connection to make a call compatible with Tarantool 1.7
- Add ClientParallelMassive benchmark
- Add runtime.Gosched for decreasing writer.flush count
- Add Eval, EvalTyped, SelectTyped, InsertTyped, ReplaceTyped, DeleteRequest, UpdateTyped, UpsertTyped methods
- Add UpdateTyped method
- Add CallTyped method
- Add possibility to pass Space and Index objects into Select etc.
- Add `RLimitAction` option
- Add `Call17()` for the connection to make a call compatible with Tarantool 1.7
- Add `ClientParallelMassive` benchmark
- Add `runtime.Gosched` for decreasing `writer.flush` count
- Add `Eval, `EvalTyped`, `SelectTyped`, `InsertTyped`, `ReplaceTyped`, `DeleteRequest`, `UpdateTyped`, `UpsertTyped` methods
- Add `UpdateTyped` method
- Add `CallTyped` method
- Add possibility to pass `Space` and `Index` objects into `Select` etc.
- Add custom MsgPack pack/unpack functions
- Add support Tarantool 1.6.8 schema format
- Add support Tarantool 1.6.5 schema format
- Add schema loading
- Add LocalAddr and RemoteAddr methods for the connection
- Add `LocalAddr` and `RemoteAddr` methods for the connection
- Add Upsert method for the connection
- Add Eval() and EvalAsync() methods for the connection
- Add `Eval()` and `EvalAsync()` methods for the connection
- Add Tarantool error codes
- Add auth support
- Add auth during reconnect
- Add auth request

## [alpha] - 2015-01-16

Alpha release. See added changes in Git.

0 comments on commit c5c01a4

Please sign in to comment.