-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replication.synchro_queue_max_size
configuration option
#4749
base: latest
Are you sure you want to change the base?
Conversation
@p7nov hey! please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a bit of a mess with commits and changes. Please fix it leaving only the related changes.
Also, some comments on the description itself from my side.
@@ -3599,6 +3600,290 @@ The ``replication`` section defines configuration parameters related to :ref:`re | |||
| Default: ``false`` | |||
| Environment variable: TT_REPLICATION_ANON | |||
|
|||
.. _configuration_reference_replication_autoexpel: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes from another PR. Please separate the changes related to the current task only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In essence, everything is correct. I think it's useful to also say: "The size limit isn't strict, i.e. if there's at least one free byte, the whole write request fits and no blocking is involved."
@p7nov pls help with this. I don't know how should I resolve it, sorry :) |
Resolves #4575.
Configuration reference: https://docs.d.tarantool.io/en/doc/gh-4575-rep-queue-max-size/reference/configuration/configuration_reference/#confval-replication.synchro_queue_max_size
Deployment: https://docs.d.tarantool.io/en/doc/gh-4575-rep-queue-max-size/reference/configuration/configuration_reference/#confval-replication.synchro_queue_max_size