Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replication.synchro_queue_max_size configuration option #4749

Open
wants to merge 20 commits into
base: latest
Choose a base branch
from

Conversation

@maryiaLichko maryiaLichko self-assigned this Jan 28, 2025
@github-actions github-actions bot temporarily deployed to branch-gh-4575-rep-queue-max-size January 28, 2025 11:34 Destroyed
@github-actions github-actions bot temporarily deployed to branch-gh-4575-rep-queue-max-size January 29, 2025 09:33 Destroyed
@maryiaLichko maryiaLichko requested a review from p7nov January 30, 2025 09:36
@maryiaLichko
Copy link
Contributor Author

@p7nov hey! please take a look

Copy link
Contributor

@p7nov p7nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bit of a mess with commits and changes. Please fix it leaving only the related changes.
Also, some comments on the description itself from my side.

@@ -3599,6 +3600,290 @@ The ``replication`` section defines configuration parameters related to :ref:`re
| Default: ``false``
| Environment variable: TT_REPLICATION_ANON

.. _configuration_reference_replication_autoexpel:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes from another PR. Please separate the changes related to the current task only.

doc/reference/configuration/configuration_reference.rst Outdated Show resolved Hide resolved
doc/reference/configuration/configuration_reference.rst Outdated Show resolved Hide resolved
doc/reference/configuration/configuration_reference.rst Outdated Show resolved Hide resolved
doc/reference/configuration/configuration_reference.rst Outdated Show resolved Hide resolved
doc/reference/configuration/configuration_reference.rst Outdated Show resolved Hide resolved
doc/reference/configuration/configuration_reference.rst Outdated Show resolved Hide resolved
Copy link

@Astronomax Astronomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In essence, everything is correct. I think it's useful to also say: "The size limit isn't strict, i.e. if there's at least one free byte, the whole write request fits and no blocking is involved."

@github-actions github-actions bot temporarily deployed to branch-gh-4575-rep-queue-max-size January 31, 2025 10:46 Destroyed
@maryiaLichko
Copy link
Contributor Author

maryiaLichko commented Jan 31, 2025

There is a bit of a mess with commits and changes. Please fix it leaving only the related changes.

@p7nov pls help with this. I don't know how should I resolve it, sorry :)

@github-actions github-actions bot temporarily deployed to branch-gh-4575-rep-queue-max-size January 31, 2025 14:32 Destroyed
@github-actions github-actions bot temporarily deployed to branch-gh-4575-rep-queue-max-size January 31, 2025 15:53 Destroyed
@github-actions github-actions bot temporarily deployed to branch-gh-4575-rep-queue-max-size February 3, 2025 10:33 Destroyed
@maryiaLichko maryiaLichko requested a review from p7nov February 3, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new configuration option: 'replication.synchro_queue_max_size'
3 participants