Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Document 'snapshot' and 'wal' configuration settings #4023

Merged
merged 10 commits into from
Feb 21, 2024

Conversation

xuniq
Copy link
Contributor

@xuniq xuniq commented Jan 25, 2024

@xuniq xuniq force-pushed the wal-snapshot-config branch 2 times, most recently from fc53820 to 134ab56 Compare February 8, 2024 08:54
@xuniq xuniq force-pushed the wal-snapshot-config branch from 134ab56 to 30f1cb5 Compare February 9, 2024 08:59
@xuniq xuniq marked this pull request as ready for review February 9, 2024 08:59
@xuniq xuniq force-pushed the wal-snapshot-config branch from 30f1cb5 to 4a03588 Compare February 12, 2024 08:54
Comment on lines +2319 to +2547
- :ref:`wal.cleanup_delay <configuration_reference_wal_cleanup_delay>`
- :ref:`wal.dir <configuration_reference_wal_dir>`
- :ref:`wal.dir_rescan_delay <configuration_reference_wal_dir_rescan_delay>`
- :ref:`wal.max_size <configuration_reference_wal_max_size>`
- :ref:`wal.mode <configuration_reference_wal_mode>`
- :ref:`wal.queue_max_size <configuration_reference_wal_queue_max_size>`
- :ref:`wal.ext.* <configuration_reference_wal_ext>`

- :ref:`wal.ext.new <configuration_reference_wal_ext_new>`
- :ref:`wal.ext.old <configuration_reference_wal_ext_old>`
- :ref:`wal.ext.spaces <configuration_reference_wal_ext_spaces>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also wal.retention_period, see https://github.com/tarantool/enterprise_doc/issues/266. The documentation request covers the new box.cfg option, but in fact it is added into the declarative configuration schema too. It seems, it is 3.1 feature (but it is better to consult with @Serpentian about all the details).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems, it is 3.1 feature

It is. Only 3.1 version

Comment on lines +2423 to +2644
Limiting the queue size might be useful when a replica is trying to sync with a master and
reads new transactions faster than writing them to the WAL.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How limiting the queue size helps in this scenario?

If WAL writes are going too slow on a replica, how more frequent flushing of the queue make thing better?

Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on these topics!

I've glanced on the updates and gave several remarks. I've no other objections and the pull request is OK for me after addressing all the comments. No need to re-review with me, but, please, reach me if something needs a discussion.

@xuniq xuniq force-pushed the wal-snapshot-config branch from 6ba72de to d191226 Compare February 19, 2024 08:59
@xuniq xuniq force-pushed the wal-snapshot-config branch from 6ce92b9 to 739e352 Compare February 20, 2024 10:30
@xuniq xuniq requested review from andreyaksenov and removed request for andreyaksenov February 20, 2024 10:55
Copy link
Contributor

@andreyaksenov andreyaksenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments below:

doc/reference/configuration/cfg_snapshot_daemon.rst Outdated Show resolved Hide resolved
doc/reference/configuration/configuration_reference.rst Outdated Show resolved Hide resolved
doc/reference/configuration/configuration_reference.rst Outdated Show resolved Hide resolved
doc/concepts/configuration/configuration_persistence.rst Outdated Show resolved Hide resolved
doc/concepts/configuration/configuration_persistence.rst Outdated Show resolved Hide resolved
doc/concepts/configuration/configuration_persistence.rst Outdated Show resolved Hide resolved
@xuniq xuniq requested a review from andreyaksenov February 20, 2024 18:09
Copy link
Contributor

@andreyaksenov andreyaksenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@xuniq xuniq merged commit d00e46b into latest Feb 21, 2024
1 check passed
@xuniq xuniq deleted the wal-snapshot-config branch February 21, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants