-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Config] Document 'snapshot' and 'wal' configuration settings #4023
Conversation
fc53820
to
134ab56
Compare
134ab56
to
30f1cb5
Compare
30f1cb5
to
4a03588
Compare
doc/code_snippets/snippets/config/instances.enabled/persistence_snapshot/config.yaml
Outdated
Show resolved
Hide resolved
- :ref:`wal.cleanup_delay <configuration_reference_wal_cleanup_delay>` | ||
- :ref:`wal.dir <configuration_reference_wal_dir>` | ||
- :ref:`wal.dir_rescan_delay <configuration_reference_wal_dir_rescan_delay>` | ||
- :ref:`wal.max_size <configuration_reference_wal_max_size>` | ||
- :ref:`wal.mode <configuration_reference_wal_mode>` | ||
- :ref:`wal.queue_max_size <configuration_reference_wal_queue_max_size>` | ||
- :ref:`wal.ext.* <configuration_reference_wal_ext>` | ||
|
||
- :ref:`wal.ext.new <configuration_reference_wal_ext_new>` | ||
- :ref:`wal.ext.old <configuration_reference_wal_ext_old>` | ||
- :ref:`wal.ext.spaces <configuration_reference_wal_ext_spaces>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also wal.retention_period
, see https://github.com/tarantool/enterprise_doc/issues/266. The documentation request covers the new box.cfg
option, but in fact it is added into the declarative configuration schema too. It seems, it is 3.1 feature (but it is better to consult with @Serpentian about all the details).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems, it is 3.1 feature
It is. Only 3.1 version
Limiting the queue size might be useful when a replica is trying to sync with a master and | ||
reads new transactions faster than writing them to the WAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How limiting the queue size helps in this scenario?
If WAL writes are going too slow on a replica, how more frequent flushing of the queue make thing better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on these topics!
I've glanced on the updates and gave several remarks. I've no other objections and the pull request is OK for me after addressing all the comments. No need to re-review with me, but, please, reach me if something needs a discussion.
6ba72de
to
d191226
Compare
6ce92b9
to
739e352
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments below:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
Fixes #4013
Fixes #3668
Fixes #3727
Fixes #3396