-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list of allowed membership uris #2300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ada209c
to
50ab561
Compare
a1div0
requested changes
Mar 6, 2025
a2e26eb
to
0659f4c
Compare
yngvar-antonsson
commented
Mar 6, 2025
a1div0
approved these changes
Mar 7, 2025
a1div0
requested changes
Mar 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow integration.expel.test_api
this test doesn't pass consistently. I tried restarting. But no. Need to figure it out. In the matrix - Tarantool 1.10, Cartridge 2.3.8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to update dependencies and introduce a new configuration option to exclude expelled members from the membership process. The most important changes are summarized below:
Dependency Updates:
membership
dependency to version2.5.0
incartridge-scm-1.rockspec
andCHANGELOG.rst
. [1] [2]New Configuration Option:
exclude_expelled_members
incartridge.cfg
to exclude expelled instances from the membership process. This change includes updates tocartridge.lua
,cartridge/argparse.lua
, andcartridge/confapplier.lua
. [1] [2] [3] [4] [5] [6] [7] [8]Documentation:
exclude_expelled_members
option inrst/cartridge_admin.rst
.Testing:
test/integration/expel_test.lua
to verify the behavior of theexclude_expelled_members
option. [1] [2] [3] [4]Code Cleanup:
fun
module fromcartridge/confapplier.lua
.I didn't forget about
Related to: https://github.com/tarantool/membership/pull/71/files