Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of allowed membership uris #2300

Merged
merged 12 commits into from
Mar 10, 2025
Merged

Conversation

yngvar-antonsson
Copy link
Collaborator

@yngvar-antonsson yngvar-antonsson commented Feb 10, 2025

This pull request includes several changes to update dependencies and introduce a new configuration option to exclude expelled members from the membership process. The most important changes are summarized below:

Dependency Updates:

  • Updated the membership dependency to version 2.5.0 in cartridge-scm-1.rockspec and CHANGELOG.rst. [1] [2]

New Configuration Option:

  • Added a new option exclude_expelled_members in cartridge.cfg to exclude expelled instances from the membership process. This change includes updates to cartridge.lua, cartridge/argparse.lua, and cartridge/confapplier.lua. [1] [2] [3] [4] [5] [6] [7] [8]

Documentation:

  • Added documentation for the new exclude_expelled_members option in rst/cartridge_admin.rst.

Testing:

  • Added new tests in test/integration/expel_test.lua to verify the behavior of the exclude_expelled_members option. [1] [2] [3] [4]

Code Cleanup:

  • Removed the unused fun module from cartridge/confapplier.lua.

I didn't forget about

  • Tests
  • Changelog
  • Documentation

Related to: https://github.com/tarantool/membership/pull/71/files

@yngvar-antonsson yngvar-antonsson requested a review from a1div0 March 6, 2025 19:20
@yngvar-antonsson yngvar-antonsson marked this pull request as ready for review March 7, 2025 09:37
@a1div0 a1div0 self-requested a review March 10, 2025 07:51
Copy link
Contributor

@a1div0 a1div0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow integration.expel.test_api this test doesn't pass consistently. I tried restarting. But no. Need to figure it out. In the matrix - Tarantool 1.10, Cartridge 2.3.8.

@yngvar-antonsson yngvar-antonsson merged commit d97bc97 into master Mar 10, 2025
25 checks passed
@yngvar-antonsson yngvar-antonsson deleted the membership-remove branch March 10, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants