Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show issue about memory usage when using large tuples #2127

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Show issue about memory usage when using large tuples #2127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a44c099
Show issue about memory usage when using large tuples
yngvar-antonsson Jul 26, 2023
1066532
Fix changelog
yngvar-antonsson Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,11 @@ Fixed
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

- Fix operation priority in Raft failover.

- Typo in ``cartridge.cfg`` option ``enable_synchro_mode``.

- Show issue about memory usage when using large tuples.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Deprecated
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Expand Down
4 changes: 4 additions & 0 deletions cartridge/issues.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,10 +331,13 @@ local function list_on_instance(opts)
local items_used_ratio = slab_info.items_used / (slab_info.items_size + 0.0001)
local arena_used_ratio = slab_info.arena_used / (slab_info.arena_size + 0.0001)
local quota_used_ratio = slab_info.quota_used / (slab_info.quota_size + 0.0001)
local total_used_ratio =
(slab_info.arena_used + slab_info.quota_used - slab_info.arena_size) / (slab_info.quota_size + 0.0001)

if items_used_ratio > vars.limits.fragmentation_threshold_critical
and arena_used_ratio > vars.limits.fragmentation_threshold_critical
and quota_used_ratio > vars.limits.fragmentation_threshold_critical
or total_used_ratio > vars.limits.fragmentation_threshold_critical
or items_used_ratio >= vars.limits.fragmentation_threshold_full
or quota_used_ratio >= vars.limits.fragmentation_threshold_full
then
Expand All @@ -354,6 +357,7 @@ local function list_on_instance(opts)
elseif items_used_ratio > vars.limits.fragmentation_threshold_warning
and arena_used_ratio > vars.limits.fragmentation_threshold_critical
and quota_used_ratio > vars.limits.fragmentation_threshold_critical
or total_used_ratio > vars.limits.fragmentation_threshold_warning
then
table.insert(ret, {
level = 'warning',
Expand Down