Fix(cfg):fix some configs' errors and remove some configs from global config list. #29704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiao-77
requested review from
guanshengliang,
hzcheng and
dapan1121
as code owners
kailixu
reviewed
Feb 8, 2025
kailixu
reviewed
Feb 8, 2025
| } | ||
|
|
||
| if (!compare) { | ||
| code = TSDB_CODE_FAILED; |
There was a problem hiding this comment.
如果执行到该行，code = failed，然后下次循环再执行到 988，code 值会被置为 0，将错误隐藏了。
kailixu
approved these changes
Feb 8, 2025
guanshengliang
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please briefly describe the code changes in this pull request.
Checklist
Please check the items in the checklist if applicable.